Not in Archive Page: Keep all controls disabled for the full duration of a download#303
Open
Not in Archive Page: Keep all controls disabled for the full duration of a download#303
Conversation
Co-authored-by: davidfstr <764688+davidfstr@users.noreply.github.com> Agent-Logs-Url: https://github.com/davidfstr/Crystal-Web-Archiver/sessions/68b88cdd-82a8-49f7-a6ff-9a71161f8402
Copilot
AI
changed the title
[WIP] Disable controls except Go Back button during download
Not in Archive Page: Keep all controls disabled for the full duration of a download
Mar 22, 2026
davidfstr
reviewed
Mar 24, 2026
src/crystal/tests/util/pages.py
Outdated
|
|
||
| @property | ||
| def go_back_button(self) -> Locator: | ||
| return self.raw_page.locator('button:has-text("← Go Back")') |
Owner
There was a problem hiding this comment.
Add CSS ID/selector like #cr-back-button instead of matching on text.
Owner
There was a problem hiding this comment.
@copilot Add CSS ID/selector like #cr-back-button instead of matching on text.
Contributor
Author
There was a problem hiding this comment.
Done in 740d1e6. Added id="cr-back-button" to the Go Back button in the Not in Archive Page HTML and updated the locator to use #cr-back-button.
Co-authored-by: davidfstr <764688+davidfstr@users.noreply.github.com> Agent-Logs-Url: https://github.com/davidfstr/Crystal-Web-Archiver/sessions/e3ed38b8-51e1-42b8-9177-7b58a6f850fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onDownloadOrCreateRootUrlButtonClicked: remove prematuresetActionInProgress(false)fromfinallyblockonDownloadOrCreateGroupButtonClicked: only callsetActionInProgress(false)when download was NOT startedgo_back_buttonproperty toNotInArchivePageinpages.pyusing#cr-back-buttonCSS IDid="cr-back-button"to the Go Back button in the Not in Archive Page HTMLOriginal prompt
Created from VS Code.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.